JavaScript: don't make EOF be a part of template string #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4n
approved these changes
Aug 27, 2017
parsers/jscript.c
Outdated
| @@ -511,11 +511,15 @@ static void parseTemplateString (vString *const string) | |||
| c = getcFromInputFile (); | |||
| if (c == '`') | |||
| break; | |||
| vStringPut (string, c); | |||
|
|
|||
| if (c != EOF) | |||
There was a problem hiding this comment.
should rather be in the previous if clause (even though it kind of makes the loop condition useless, but still):
if (c == '`' || c == EOF)
break;EOF char was mistakenly appended to a token of template string. Close universal-ctags#1493. Merging conditions is suggested by @b4n. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
handle-eof-in-template-string-of-jscript
branch
from
004d0c5
to
fe7e03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOF char was mistakenly appended to a token of template string.
Close #1493.
Signed-off-by: Masatake YAMATO yamato@redhat.com