Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seq: eliminate special handling of -0.0 #2870

Closed
jfinkels opened this issue Jan 15, 2022 · 2 comments
Closed

seq: eliminate special handling of -0.0 #2870

jfinkels opened this issue Jan 15, 2022 · 2 comments
Labels
good first issue For newcomers! U - seq

Comments

@jfinkels
Copy link
Collaborator

jfinkels commented Jan 15, 2022 •
edited
Loading

The seq program contains a lot of code for representing and displaying floating point negative zero (-0.0f32, for example). It should be possible to eliminate some of this code once the minimum supported version of Rust reaches v1.52.0 or greater. See the comments in pull request #2698 for more information.

Pull request #2869 proposes increasing the minimum version to v1.54.0, so that would allow this change.

See rust-lang/rust#78618 for information on the relevant feature of Rust.
@tertsdiepraam
Copy link
Member

The MSRV is now 1.54, so this is unblocked.

@tertsdiepraam tertsdiepraam changed the title seq: when MSRV reaches 1.52.0 or greater, eliminate special handling of -0.0 seq: eliminate special handling of -0.0 Jan 19, 2022
This was referenced Feb 4, 2022
Closed
Merged
@palaster
Copy link
Contributor

This can be closed because of this #3056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - seq
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfinkels @palaster @tertsdiepraam