[Bug]: Visor reports invalid value for the attempts left

[daniel1302]

Problem encountered

This is low priority I guess

When We start visor from network history it decreases the attemptLeft from 10 and at some point it becomes negative. It is confusing why the left attempts may be negative.

Another thing is that even if we hit 0 and negative value the node will be able to start

2024-05-04T23:23:39.459+0200    DEBUG   visor   visor/visor.go:175      Failed to get upgrade status from API   {"error": "failed to get protocol update status: request failed: Post \"http://unix/rpc\": dial unix /home/daniel/www/snapshot-testing/workdir/vega.sock: connect: connection refused"}
2024-05-04T23:23:39.459+0200    INFO    visor   visor/visor.go:179      Still waiting for vega to start...      {"attemptLeft": -47}

Observed behaviour

1. Visor reports "attemptLeft": as negative
2. attempts left is not working
3. attempts left is by default 10 which is not enough.

Expected behaviour

1. attempts left should be reported correctly
2. attempts left should work
3. attempts left should be bigger by default

Steps to reproduce

1. Start a node from the network history
2. Use bigger number for the network history segments blocks

Software version

v0.76.0

Failing test

No response

Jenkins run

No response

Configuration used

No response

Relevant log output

No response

[daniel1302]

I think we need to fix it because I cannot start data-node sometimes:

I am getting the following error:

May 10 12:20:34 monitoring-mainnet visor[12833]: Error: failed to get upgrade status for maximum amount of 10 times: failed to get protocol update status: request failed: Post "http://unix/rpc": dial unix /
tmp/vega.sock: connect: connection refused

More logs is here:
vegavisor.log

But it is my config:

vega@monitoring-mainnet:~$ cat /mnt/vega/vegavisor_home/config.toml
maxNumberOfFirstConnectionRetries = 43200
maxNumberOfRestarts = 3
restartsDelaySeconds = 5
stopDelaySeconds = 0
stopSignalTimeoutSeconds = 15

[autoInstall]
  enabled = true
  repository = "vega"
  repositoryOwner = "vegaprotocol"

  [autoInstall.asset]
    binaryName = "vega"
    name = "vega-linux-amd64.zip"

[upgradeFolders]
  "vX.X.X" = "vX.X.X"