Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to an automatically-generated blurry placeholder #24875

Closed
atcastle opened this issue May 6, 2021 · 3 comments
Closed

Fallback to an automatically-generated blurry placeholder #24875

atcastle opened this issue May 6, 2021 · 3 comments
Assignees
Labels
please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity type: chrome

Comments

@atcastle
Copy link
Collaborator

atcastle commented May 6, 2021

In PR #24153 @Joonpark13 added a feature to allow the image component to display a blurry placeholder that's passed to it in the form of a URL (inline dataURL or actual URL). Methods for automatically supplying this URL to the image component are currently in development, but I think it would also be a good idea to add a fallback behavior to the component where the specified loader is used to generate a very small (10 px wide or less) image to be used as the blurry placeholder.

The reason this is the fallback behavior rather than the intended general use case is that performance will be better if the placeholder can be rendered (as a dataURL) at serve- or build-time. Having a remote URL for the placeholder introduces an extra network round trip before the placeholder can be displayed.

Having this functionality available as a fallback will allow for wider beta testing of the blurry placeholder feature, and will help cover corner cases where we may not be able to server-side render the placeholder.

@jankaifer jankaifer self-assigned this Dec 1, 2022
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@styfle
Copy link
Member

styfle commented Dec 1, 2022

This was implemented in Next.js 11

https://nextjs.org/blog/next-11#image-placeholders

@styfle styfle closed this as completed Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity type: chrome
Projects
None yet
Development

No branches or pull requests

4 participants