Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$TURBO_DEFAULT$ doesn't work as default anymore in 1.13.3 #8203

Closed
1 task done
ChurroC opened this issue May 23, 2024 · 2 comments
Closed
1 task done

$TURBO_DEFAULT$ doesn't work as default anymore in 1.13.3 #8203

ChurroC opened this issue May 23, 2024 · 2 comments
Assignees
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo

Comments

@ChurroC
Copy link

ChurroC commented May 23, 2024

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://codesandbox.io/p/github/ChurroC/next-server-theme/main?import=true

What package manager are you using / does the bug impact?

npm, Yarn v1, bun

What operating system are you using?

WSL but also tested on code sandbox

Which canary version will you have in your reproduction?

Tried on 1.13.4-canary.5 and on stable 1.13.3

Describe the Bug

When adding $TURBO_DEFAULT$ to inputs, turbo doesn't recognize it and instead caches no matter the change. Cache revalidation worked perfectly without $TURBO_DEFAULT$. But the second I used it as an input it served the cached run no matter what.

Expected Behavior

$TURBO_DEFAULT$ should work the same as the default inputs and even more important should invalidate the cache when files change.

To Reproduce

You can use the repo and first do yarn install.
Then do yarn run build --filter web. This will run build step of web package. It'll work find with no input section.
If you add "inputs": ["$TURBO_DEFAULT$" to build you end up having no cache invalidation.

Additional context

Video of me testing on the code sandbox https://drive.google.com/file/d/1g9YsqGOQMxoyC8y0myBaiaegbwm5EOYX/view
turbo json - next-server-theme - CodeSandbox (1)

Also tested on 1.13.0 and everything started working

@ChurroC ChurroC added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels May 23, 2024
@ChurroC ChurroC changed the title $TURBO_DEFAULT$ doesn't work as default anymore $TURBO_DEFAULT$ doesn't work as default anymore in 1.13 May 23, 2024
@ChurroC ChurroC changed the title $TURBO_DEFAULT$ doesn't work as default anymore in 1.13 $TURBO_DEFAULT$ doesn't work as default anymore in 1.13.3 May 23, 2024
@NicholasLYang
Copy link
Contributor

Hey @ChurroC, thanks for the issue. Could you try running with --no-daemon? It's possible that the daemon's implementation of file hashing is incorrect.

@ChurroC ChurroC closed this as completed May 25, 2024
@chris-olszewski chris-olszewski self-assigned this May 28, 2024
@rozsival
Copy link

In case this is going to be investigated / fixed later on, I confirm in our project the combination of $TURBO_DEFULT$ and daemon was the problem too. Switching to --no-daemon mode solved the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

No branches or pull requests

4 participants