Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lang/zh.js file from build #1878

Closed
Globulopolis opened this issue Feb 18, 2015 · 5 comments
Closed

Remove lang/zh.js file from build #1878

Globulopolis opened this issue Feb 18, 2015 · 5 comments

Comments

@Globulopolis
Copy link

According to latest changes in language files I suggest remove zh.js file from build because he not needed anymore.

PS! For more info see PRs #1729 and #1841

@heff
Copy link
Member

heff commented Feb 19, 2015

Interesting. I don't know why that would still be in the dist. There's no zh.json in the lang folder. There must be something with our language build step.

@seniorflexdeveloper can you tell what might be going on here (since you originally put together the grunt task)?

@gkatsev
Copy link
Member

gkatsev commented Feb 19, 2015

It's in the dist: https://github.com/videojs/video.js/tree/v4.12.0/dist/video-js/lang
@heff maybe you still had the file locally when making the build?

@heff
Copy link
Member

heff commented Feb 19, 2015 via email

@tomjohnson916
Copy link
Contributor

@heff - I'm not sure what language that is. It's definitely not in our standard array. Also the grunt task just normalizes the JSON -> JS process and src/dest locations.

@heff
Copy link
Member

heff commented Feb 19, 2015

Yeah, I think the issue here is that we need to add a step in the dist process that clears out any existing files.

@mmcc mmcc closed this as completed Jul 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants