Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 doesn't fire addtrack or removetrack events on native text tracks #2465

Closed
gkatsev opened this issue Aug 11, 2015 · 9 comments
Closed
Milestone

Comments

@gkatsev
Copy link
Member

gkatsev commented Aug 11, 2015

I noticed this as part of trying to fix tests in master for #2454. Some of the async tests would hang because these events would never fire.
It would be nice to see if we can fake these events but we probably can't.

@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

One way to fix it is to force emulated captions for browsers that cannot fire the removetrack event.

'removetrack' in Html5.TEST_VID.textTracks

@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

Thoughts, @videojs/core-committers

@heff
Copy link
Member

heff commented Aug 12, 2015

It looks like IE has an onaddtrack property, but it only works if you use the addTextTrack API...boo. Is there somewhere we can submit a bug for IE?

Seems like we'll need the native one if projects like dash.js are interacting with the video element directly, so this seems reasonable. You probably need to change 'removetrack' to 'onremovetrack'

@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

Oops, yep, I meant onremovetrack. We could probably file a bug on modern.ie. I'll look into doing that.

@gkatsev gkatsev added this to the Text Tracks milestone Aug 12, 2015
@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

Looks like IE11 doesn't fir it if we attach the events via onaddtrack or onremovetrack. Will file an issue with them. Possibly the same issue as #2438.

@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

Yep, looks like Edge is the same issue.

@gkatsev
Copy link
Member Author

gkatsev commented Aug 12, 2015

@heff
Copy link
Member

heff commented Aug 12, 2015

Can we close this because of #2466?

@gkatsev
Copy link
Member Author

gkatsev commented Aug 13, 2015

Since we filed the bug and disabled native tracks on IE11/Edge, both this and #2438 can be closed.

@gkatsev gkatsev closed this as completed Aug 13, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants