Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio flash fallback not working #533

Closed
tomsaffell opened this issue May 23, 2013 · 4 comments
Closed

Audio flash fallback not working #533

tomsaffell opened this issue May 23, 2013 · 4 comments

Comments

@tomsaffell
Copy link

Passing {type: 'audio/mp3', src'url-to-an-mp3-file'} to .src() causes the audio to play in Chrome (and IE9) within the video element.

On Firefox (on Win 7), which does not support the mp3 codec, there is no fallback to Flash.

I have made changes to the JS and AS to remedy this:
tomsaffell/video-js-swf@b8bfd1c
tomsaffell@f6782c8

There are still issues to fix before we can declare audio 'done', hence this issue. To name a few:

  1. the flash has no controls for controlling the audio
  2. calling .src() for a video does not stop the mp3 playing
  3. the regex that detects mp3s in the SWF is prone to false negatives
  4. playing a video, then audio, leaves the the video frame showing
@heff heff mentioned this issue May 24, 2013
@heff
Copy link
Member

heff commented May 24, 2013

Created #537 to address this

@heff heff closed this as completed May 24, 2013
@tim-peterson
Copy link

Some issues with using the <video> tag for audio support:

  1. On mobile safari/chrome, playing the audio sends the content fullscreen because the default behavior for videos is fullscreen. Supposedly this default behavior is only true for iPhone but not iPad. I only tested iPhone. Forced fullscreen mode is undesirable both because you lose the quick navigation to other parts of the screen and because the audio has no images to fill the screen and you just get an ugly blank full screen or quicktime image. This can supposedly be addressed by adding the webkit-playsinline attribute to the <video> tag but in many people's testing including my own this attribute has no effect. see SO for discussion
  2. The audio can only be played by clicking on the poster. It can not be paused.

@heff
Copy link
Member

heff commented Jun 26, 2013

That's good to know, thanks. We'll definitely need to implement support for the audio tag specifically then.

On Jun 13, 2013, at 8:27 AM, tim peterson notifications@github.com wrote:

Some issues with using the

on mobile safari/chrome, playing the audio sends the content fullscreen because the default behavior for videos is fullscreen. This is undesirable because there is no image to fill the screen and you just get the ugly blank or quicktime screen. This can supposedly be addressed by adding the webkit-playsinline attribute to the

@tim-peterson
Copy link

I think the tag is the way to go. I realized there was a simple fix for preventing fullscreen is to use the audio tag combined with the option "customControlsOnMobile": true, which shows the controls on mobile.

Please see this demo with both video and audio tags implemented and both with playlists:

http://tim-peterson.github.io/videojs-playlist/

On Jun 26, 2013, at 7:29 PM, Steve Heffernan wrote:

That's good to know, thanks. We'll definitely need to implement support for the audio tag specifically then.

On Jun 13, 2013, at 8:27 AM, tim peterson notifications@github.com wrote:

Some issues with using the

on mobile safari/chrome, playing the audio sends the content fullscreen because the default behavior for videos is fullscreen. This is undesirable because there is no image to fill the screen and you just get the ugly blank or quicktime screen. This can supposedly be addressed by adding the webkit-playsinline attribute to the


Reply to this email directly or view it on GitHub.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants