Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle minor touchmoves in tap events #677

Closed
heff opened this issue Aug 9, 2013 · 2 comments
Closed

Handle minor touchmoves in tap events #677

heff opened this issue Aug 9, 2013 · 2 comments

Comments

@heff
Copy link
Member

heff commented Aug 9, 2013

First referenced here:
#672 (comment)

Currently the tap event is only fired with the following sequence:

  • a touchstart event is fired
  • no touchmove or touchleave events are fired
  • a touchend event is fired

But there may be cases where the user's finger moves slightly during the tap, causing a mousemove. We should account for this by allowing for ~10px of movement during the tap event.

The tap code is in component.js
https://github.com/videojs/video.js/blob/master/src/js/component.js

@heff heff added the unclaimed label Mar 4, 2014
@heff
Copy link
Member Author

heff commented May 1, 2014

Being fixed by #1111

@heff
Copy link
Member Author

heff commented May 7, 2014

Fixed by #1111

@heff heff closed this as completed May 7, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant