Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering/pixeldata.py skipped tests are darker in parallel #18685

Open
JustinPrivitera opened this issue May 5, 2023 · 1 comment
Open

rendering/pixeldata.py skipped tests are darker in parallel #18685

JustinPrivitera opened this issue May 5, 2023 · 1 comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer

Comments

@JustinPrivitera
Copy link
Member

Describe the bug

These tests are in the skip list for all platforms because when run in parallel, the images come out darker. Even when run in parallel with just one process.

image

Expected behavior

This should be identical to the serial version of the tests.

Desktop

  • OS and version: LC toss3
  • VisIt Version: develop
@JustinPrivitera JustinPrivitera added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels May 5, 2023
@markcmiller86
Copy link
Member

The testing @JustinPrivitera did here included a case where we ran parallel (not scalable or iceT) on a single processor...and still got different results from serial. This lead to the idea of another kind of test mode...we run single processor parallel and ensure it generates the same results as serial. If it does not, it suggests there are parallel code blocks that do not match their serial counterparts.

@brugger1 brugger1 added the reviewed Issue has been reviewed and labeled by a developer label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood reviewed Issue has been reviewed and labeled by a developer
Projects
None yet
Development

No branches or pull requests

3 participants