Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: esbuild minification and renderLegacyChunks false #5054

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

DreierF
Copy link
Contributor

@DreierF DreierF commented Sep 23, 2021

Description

When using vite 2.6.0-beta.2 together with plugin-legacy and renderLegacyChunks set to false the build fails with

Error: Can't use esbuild as the minifier when targeting legacy browsers because esbuild minification is not legacy safe.

even though no legacy code is generated that might be incompatible with esbuild.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title fix: Build failure when using esbuild as minifier and renderLegacyChunks false fix: esbuild minification and renderLegacyChunks false Sep 23, 2021
@patak-dev patak-dev merged commit ed384cf into vitejs:main Sep 23, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@DreierF DreierF deleted the fix_esbuild_legacy branch May 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants