Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): only run require-import conversion if require'd #8795

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

sapphi-red
Copy link
Member

Description

#8459 introduced external require-import conversion but it was applied not only to CJS.
It made reload by "newly found deps" happening frequently.

This PR makes the conversion only applied to CJS.
#8459's test covers this change.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Jun 26, 2022
@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit e8f8d30
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62b836f77628540008b84cb6
😎 Deploy Preview https://deploy-preview-8795--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sapphi-red sapphi-red added this to the 3.0 milestone Jun 26, 2022
@patak-dev patak-dev changed the title fix(optimizer): only run require-import conversion if it was called by require fix(optimizer): only run require-import conversion if require'd Jun 26, 2022
@patak-dev patak-dev merged commit 7ae0d3e into vitejs:main Jun 26, 2022
@sapphi-red sapphi-red deleted the fix/reduce-optimize-reload branch June 26, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants