Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template-react-ts warning when importing path in vite.config.ts #8924

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

andyjxli
Copy link
Contributor

@andyjxli andyjxli commented Jul 5, 2022

Description

fix: template-react-ts is warning when I import path in vite.config.ts
企业微信截图_b4f69cf5-7761-4f94-a14d-4ca1c753e1d8

Additional context


What is the purpose of this pull request?

  • [-] Bug fix
  • New Feature
  • Documentation update
  • Other

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6d11fd4
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62c3e68b21c97400093ba184

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a harmless addition as it's for the vite config only.

@andyjxli andyjxli closed this Jul 5, 2022
@andyjxli andyjxli reopened this Jul 5, 2022
@andyjxli andyjxli requested a review from bluwy July 5, 2022 08:01
@andyjxli
Copy link
Contributor Author

andyjxli commented Jul 5, 2022

Should be a harmless addition as it's for the vite config only.

tests have runed, please see again~~, thanks

@bluwy
Copy link
Member

bluwy commented Jul 5, 2022

You can ignore the failing tests as it's flaky 🙂 The change in this PR isn't covered by CI so it should be safe.

@andyjxli
Copy link
Contributor Author

andyjxli commented Jul 5, 2022

You can ignore the failing tests as it's flaky 🙂 The change in this PR isn't covered by CI so it should be safe.

OK,thank you~ 😄

@patak-dev patak-dev changed the title fix: template-react-ts is warning when I import path in vite.config.ts fix: template-react-ts warning when importing path in vite.config.ts Jul 5, 2022
@patak-dev patak-dev merged commit 0e6b82e into vitejs:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants