From 9038bf445295244046d96e00c1f5a162b1df694c Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Fri, 19 Feb 2021 21:35:35 +0530 Subject: [PATCH 1/2] fix: update prompt message based on user input --- packages/create-app/index.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/create-app/index.js b/packages/create-app/index.js index 89845a0e86e106..5a16a9ee019ac2 100755 --- a/packages/create-app/index.js +++ b/packages/create-app/index.js @@ -76,12 +76,17 @@ async function init() { // determine template let template = argv.t || argv.template - - const availableTemplates = TEMPLATES.map((template) => stripColors(template)) - const isValidTemplate = availableTemplates.includes(template) - const message = isValidTemplate - ? `Select a template:` - : `${template} isn't a valid template. Please choose from below: ` + let message = 'Select a template:' + let isValidTemplate + + // --template expects a value + if (template && typeof template === 'string') { + const availableTemplates = TEMPLATES.map((template) => + stripColors(template) + ) + isValidTemplate = availableTemplates.includes(template) + message = `${template} isn't a valid template. Please choose from below:` + } if (!template || !isValidTemplate) { /** From 076901c27bd798badca87f4072b21804b45917bc Mon Sep 17 00:00:00 2001 From: James George Date: Fri, 19 Feb 2021 22:30:37 +0530 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Evan You Co-authored-by: CHOYSEN --- packages/create-app/index.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/create-app/index.js b/packages/create-app/index.js index 5a16a9ee019ac2..489c7f02ace65b 100755 --- a/packages/create-app/index.js +++ b/packages/create-app/index.js @@ -77,13 +77,11 @@ async function init() { // determine template let template = argv.t || argv.template let message = 'Select a template:' - let isValidTemplate + let isValidTemplate = false // --template expects a value - if (template && typeof template === 'string') { - const availableTemplates = TEMPLATES.map((template) => - stripColors(template) - ) + if (typeof template === 'string') { + const availableTemplates = TEMPLATES.map(stripColors) isValidTemplate = availableTemplates.includes(template) message = `${template} isn't a valid template. Please choose from below:` }