expect.poll.toBeDefined is broken

[dmaretskyi]

Describe the bug

This test should not be passing, but passes anyway:

test('expect poll', async ({ expect }) => {
  await expect.poll(() => undefined).toBeDefined();
});

Reproduction

https://stackblitz.com/edit/vite-ssr-map-sources-trkjjk?file=repro.test.js

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^5.4.7 => 5.4.7 
    vitest: ^2.1.1 => 2.1.1

Used Package Manager

pnpm

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[hi-ogawa]

It looks like "not" state get confused due to toBeDefined definition here and 2nd poll attempt get succeed:

vitest/packages/expect/src/jest-expect.ts

Lines 386 to 395 in 2a50464

	def('toBeDefined', function () {
	const negate = utils.flag(this, 'negate')
	utils.flag(this, 'negate', false)
	if (negate) {
	return this.be.undefined
	}
	return this.not.be.undefined
	})