Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export WatsonMiddleware typescript definition for re-use #165

Conversation

rob-pocklington-a139759
Copy link
Contributor

Exports WatsonMiddleware so 3rd party code can make use of these type definitions.

I also moved the Payload and ContextDelta interfaces to be in the Middleware interface, should not be a breaking change since they weren't exported previously.

Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@germanattanasio
Copy link
Contributor

I'm going to merge this and release it as a minor update

btw: @rob-pocklington-a139759 you need to update your git configuration with your email from github otherwise you won't see your contributions.

@germanattanasio germanattanasio merged commit bb9bc83 into watson-developer-cloud:master Feb 18, 2019
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 1.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants