Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleteUserData #186

Closed
Naktibalda opened this issue Jun 14, 2019 · 1 comment · Fixed by #188
Closed

deleteUserData #186

Naktibalda opened this issue Jun 14, 2019 · 1 comment · Fixed by #188
Assignees
@germanattanasio
Labels
enhancement feature New functionality not yet supported released

Comments

@Naktibalda
Copy link
Contributor

I would like to invoke deleteUserData method of AssistantV1 class in ibm-watson package
and I would like to use an existing instance of AssistantV1 from watson middleware to do that,
but conversation property is marked as private, so I can't access it.
https://github.com/watson-developer-cloud/botkit-middleware/blob/v2.1.1/src/index.ts#L58

What would be the best way to solve this issue?

  • Make conversation property public,
  • Add getConversation method,
  • Add deleteUserData(customerId: string) method,
  • Import AssistantV1 from ibm-watson package and create a new instance of it?
@Naktibalda Naktibalda added enhancement feature New functionality not yet supported labels Jun 14, 2019
@Naktibalda Naktibalda mentioned this issue Jun 17, 2019
Merged
@watson-github-bot
Copy link
Member

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germanattanasio germanattanasio

Labels
enhancement feature New functionality not yet supported released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/delete user data watson-developer-cloud/botkit-middleware
3 participants
@germanattanasio @Naktibalda @watson-github-bot