This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Bump to kubeyaml 0.5.1 to fix (F)HR updating #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeyaml 0.5.1 has a fix for updating images that include ports in (Flux)HelmRelease manifests. So: bump that in the Dockerfile and shim (`/bin/kubeyaml`), and add a test that it does account for such images when updating. Side issue in update_test.go: calling `t.Parallel()` _before_ invoking the test case meant that the closed-over loop variable could be reassigned before the test case was run.
|
Roli, do you mind having a look at this? Checking that the additional test actually tests something that could (and previously, did) fail would be adequate I reckon. |
rndstr
approved these changes
Nov 14, 2018
|
Thanks @rndstr 🍧 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubeyaml 0.5.1 has a fix for updating images that include ports in
(Flux)HelmRelease manifests. So: bump that in the Dockerfile and shim
(
/bin/kubeyaml), and add a test that it does account for such imageswhen updating.
Side issue in update_test.go: calling
t.Parallel()before invokingthe test case meant that the closed-over loop variable could be
reassigned before the test case was run.
Fixes #1504.