This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Reduce spam log generated by registry cache warmer #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- log the rate limit error once per image repository
squaremo
suggested changes
Nov 21, 2018
squaremo
approved these changes
Nov 21, 2018
stefanprodan
changed the title
|
The automated updates are not working, I'm investigating it... |
|
The cancelable context will block forever after the cancel event, so I've used the passed context in the select and the cancelable one for client manifest fetching. The automated updates are working fine now. |
stefanprodan
changed the title
|
The blocking was caused by the wait group, that's being fixed in the latest commit. Ready to merge 🔨 |
This was referenced Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1529