This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Default to fluxctl use for getting git deploy key #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a while we gave people a set of commands to extract the git deploy key from flux logs. Now that it's gotten easier to install fluxctl (and there's lots of benefits to using it anyway), let's default to using "fluxctl identity" Closes: #1179 Signed-off-by: Daniel Holbach <daniel@weave.works>
|
I picked Stefan as reviewer as the PR touched on the Helm charts he contributed, but I'd value everyone's else's thoughts too. |
hiddeco
approved these changes
Nov 25, 2018
stefanprodan
suggested changes
Nov 25, 2018
chart/flux/templates/NOTES.txt
Outdated
| 2. Get the Git deploy key by running these commands: | ||
| export FLUX_POD=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "flux.name" . }},release={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}") | ||
| kubectl -n {{ .Release.Namespace }} logs $FLUX_POD | grep identity.pub | cut -d '"' -f2 | ||
| 2. Get the Git deploy key by installing fluxctl |
There was a problem hiding this comment.
I would replace option 1. from above with:
kubectl -n {{ .Release.Namespace }} logs deployment/{{ .Release.Name }} | grep identity.pub | cut -d '"' -f2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while we gave people a set of commands to extract the git deploy key from flux logs. Now that it's gotten easier to install fluxctl (and there's lots of benefits to using it anyway), let's default to using
"fluxctl identity"
Closes: #1179