Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Avoid panic when serialisation fails #591

Open
1xstj opened this issue May 2, 2023 · 0 comments
Open

[BUG] Avoid panic when serialisation fails #591

1xstj opened this issue May 2, 2023 · 0 comments
Assignees
@1xstj
Labels
p1 🟠 Issue should be resolved sooner than later

Comments

@1xstj
Copy link
Contributor

1xstj commented May 2, 2023

Describe the bug

dkg-substrate/dkg-gadget/src/async_protocols/state_machine_wrapper.rs

Line 90 in 75f0bfa

let msg_serde = bincode2::serialize(&msg).expect("Failed to serialize message");

If the serialisation fails the whole process fails, switch to serde_json
@1xstj 1xstj added the p1 🟠 Issue should be resolved sooner than later label May 2, 2023
@1xstj 1xstj self-assigned this May 2, 2023
@1xstj 1xstj mentioned this issue May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1xstj 1xstj

Labels
p1 🟠 Issue should be resolved sooner than later
Projects
Webb Universe
Status: Planning 🗺️
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1xstj