-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elements of NilReasonType must have nillable attribute set #14
Comments
The majority of the elements listed above are of StringWithNilReason type which the absence of a string is valid. This means the nillable attribute (i.e., 'xsi:nil') is optional for StringWithNilReason elements and not explicitly required in order to be valid. But this behavior is inconsistent with the other 'WithNilReason' types as they do require 'xsi:nil=true' to be set in order to be valid. The volcanicAshAdvisory/summitElevation element type is LengthWithNilReason. In the cases of summitElevation being set to 'SFC' or 'UNKNOWN', using the nilReason attribute alone is not sufficient, and resulting XML not valid: the nillable attribute is not provided. The pull-request associated with this issue, 17053f5, fixes that and makes the StringWithNilReason elements consistent with the other 'WithNilReason' elements. |
Thank you. I have added nillable="true" to all the above mentioned in IWXXM 3.1 except iwxxm:summitElevation, as the actual element containing LengthWithNilReason has changed to iwxxm:summitElevation/iwxxm:Summit/iwxxm:elevation (see wmo-im/iwxxm#219 (comment)). |
On review of the schemas, the following elements in bold do not have the attribute metarSpeci.xsd: if trend forecast does not specify a time period, iwxxm:phenomenonTime is nilled with unknown or missing sigmet.xsd: if iwxxm:VolcanicAshSIGMETPositionCollection is nilled with nothingOfOperationalSignificance spaceWeatherAdvisory.xsd: if iwxxm:locationIndicator is nilled with inapplicable taf.xsd: if no significant cloud (NSC) is forecast, iwxxm:cloud is nilled with nothingOfOperationalSignificance tropicalCycloneAdvisory.xsd: if last advisory, iwxxm:nextAdvisoryTime is nilled with inapplicable volcanicAshAdvisory.xsd: if last advisory, iwxxm:nextAdvisoryTime is nilled with inapplicable |
The following schema/elements do not have the nillable attributes set. WIthout them, the elements cannot be made, well, nillable.
The text was updated successfully, but these errors were encountered: