Header: Allow custom (unlinked) content in a navigation item

[paulrobertlloyd]

It’s currently not possible to pass in anything into a navigation item other than a link. With the following params:

<% component.slot(:item, title: 'Navigation item') %>

the following HTML is returned:

<li class="govuk-header__navigation-item">
  <a class="govuk-header__link" href>Navigation item</a>
</li>

A link with an empty href is not the desired – or possibly expected – outcome. What’s needed is a means of providing text only content (which is unlinked without the presence of href). For example:

<% component.slot(:item, title: 'I like apples') %>

would generate the following markup:

<li class="govuk-header__navigation-item">
  I like apples
</li>

Additionally, it would be good if block content could be provided. For example:

<%= component.slot(:item) do %>
  I <em>really</em> like apples
<% end %>

the following markup would be generated:

<li class="govuk-header__navigation-item">
  I <em>really</em> like apples
</li>

For reference, the GDS Nunjucks macro provides the following options for navigation items:

Name	Type	Description
text	string	Required. Text for the navigation item. If html is provided, the text argument will be ignored.
html	string	Required. HTML for the navigation item. If html is provided, the text argument will be ignored.
href	string	Url of the navigation item anchor.
active	boolean	Flag to mark the navigation item as active or not.
attributes	object	HTML attributes (for example data attributes) to add to the navigation item anchor.

---

Sidenote: The title value ought to be called text. This would not only align it with the GDS Nunjucks macros, but also other components in this gem (where a text param can be overwritten by block content).