-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarking not working using pytest #191
Comments
Interesting...maybe something to do with missing pytest-benchmark (it had to be added to specs)? I'll poke around |
@nikitakuklev do you think you'll be able to fix this today? If not I think I will remove the benchmarking files for now and we can add it back in later. We are trying to do a release |
In what environment does this fail? Can you verify it was updated with the new pytest-benchmark dependency? On my windows machine runs fine, even when combining tests and benchmarks with a simple 'pytest tests'. |
Ok it works with the additional pytest-benchmark dependency, can we move it out of the tests dir at least? Running tests is supposed to be a quick process. I can do the PR if you want |
The run_tests script excludes benchmarks with '--ignore=tests/benchmarks', but yes we can move it out. Please go ahead with PR. |
Done #192 |
Using running pytest on Xopt/tests fails due to the benchmarking code giving the error below:
The text was updated successfully, but these errors were encountered: