Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method setOptions must honor the type of option param #11

Closed
yriveiro opened this issue Apr 25, 2018 · 0 comments
Closed

Method setOptions must honor the type of option param #11

yriveiro opened this issue Apr 25, 2018 · 0 comments

Comments

@yriveiro
Copy link
Owner

The documentation of this method says that option param it's an array. We are converting internally the param option to an array if it's not. This can be done forcing the type of the param in the signature method.

The signature method:

public function setOptions($options) : BackoffInterface

should be:

public function setOptions(array $options) : BackoffInterface

This can break some scenarios, but this behaviour is wrong and should be corrected.

@yriveiro yriveiro changed the title setOptions must honor the type of option param Method setOptions must honor the type of option param Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant