-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: react color picker #125
Conversation
✅ Deploy Preview for analysis-ui-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@targos it needs too many changes to be in a good shape to be included in our package, I will start moving part by part from js to ts, currently, i replaced the class component with the functional component and be sure that the component work as before |
@hamed-musallam ok. Just try to rebase your PR on the main branch to remove the commits that are already there. |
ed84b3f
to
a0fbc36
Compare
done |
do you think we have to refactor it or we can keep it like that? |
There is still 800f783 to be removed |
We should at least refactor it to remove |
- clone sketch component from https://github.com/casesandberg/react-color - move all components to functional components instead of classes.
a0fbc36
to
d1cf0d8
Compare
- remove reactcss - remove lodash/merge
i removed reactcss and replace it with inline style, can you check the component and see if we need more changes? |
Should the package not expose this ColorPicker ? Should the component itself not be called ColorPicker ? I find the storyboard confusing to have a component ColorPicker that is loading a component Sketcher. |
Yes, the component should be called ColorPicker. And please fix the merge conflict. |
Also, please rename the |
4530c49
to
6670fe9
Compare
This reverts commit 4a7877b.
@hamed-musallam I made a few fixes on the types and some cleanup. Is it ready from your PoV? |
@targos |
Thanks, released in v0.14.0 |
- clone sketch component from https://github.com/casesandberg/react-color - move all components to functional components instead of classes. Co-authored-by: Michaël Zasso <targos@protonmail.com>
we still need to move the js to ts and refactor the whole components, this PR is just to approve that the clone version of the package is working after i remove the classes and use the functional component code base