Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: side panel not initially closed #176

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

hamed-musallam
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for analysis-ui-components ready!

Name Link
🔨 Latest commit 3a0c831
🔍 Latest deploy log https://app.netlify.com/sites/analysis-ui-components/deploys/62bc1a7a94aec40008ccb428
😎 Deploy Preview https://deploy-preview-176--analysis-ui-components.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hamed-musallam
Copy link
Contributor Author

@targos

can you accept and merge this PR?

@targos
Copy link
Member

targos commented Jun 29, 2022

@hamed-musallam Can you please improve the commit message and add a Fixes: line?

@hamed-musallam
Copy link
Contributor Author

@targos

can you show me what you mean?

@targos
Copy link
Member

targos commented Jun 29, 2022

For example:

fix: keep side panel closed when initialClosed is passed

Closes: https://github.com/zakodium-oss/analysis-ui-components/issues/175

@hamed-musallam
Copy link
Contributor Author

@targos

sorry for this question, what is the problem with this commit message

fix: side panel not initially closed
close #175

@targos
Copy link
Member

targos commented Jun 29, 2022

Your initial commit message doesn't contain the "close #175". It's technically OK for GitHub to write it like that but we try to comply to the Conventional Commits specification. In particular here:

  • The commit description must be a summary of the changes (=what the commit does, not what it fixes)
  • Footers (like Close:, Closes:, Fixes: etc) need a colon to be in the git trailer format. They also need to be separated from the rest of the message by an empty line

@targos targos merged commit 6a7cb00 into zakodium-oss:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants