-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update!: support for fileCollection and guess the spectra type #246
Conversation
✅ Deploy Preview for analysis-ui-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 91.85% // Head: 88.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 91.85% 88.39% -3.47%
==========================================
Files 8 8
Lines 491 491
Branches 80 79 -1
==========================================
- Hits 451 434 -17
- Misses 40 57 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
* update: support for fileCollection and classification of spectra * update: a few missing types, and prettify * test: disable temporarely getIVMeasurement * chore: rename files to fileCollection * chore: add todo to use FiltCollection.filter Co-authored-by: Luc Patiny <luc@patiny.com>
* wip: prepare cary500Loader * update!: support for fileCollection and guess the spectra type (#246) * update: support for fileCollection and classification of spectra * update: a few missing types, and prettify * test: disable temporarely getIVMeasurement * chore: rename files to fileCollection * chore: add todo to use FiltCollection.filter Co-authored-by: Luc Patiny <luc@patiny.com> * feat: add experimental cary500Loader * chore: update dependencies and add testcase * chore: add missing vitest import * chore: fix prettier Co-authored-by: Santiago Miranda <santimir@protonmail.com>
Error coming from the new parser version (biologic) so it needs fixing.
Fixings, style, comments, recommendations etc are welcome. 😃