Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render explicit string literals for representing boolean values #589

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

hamed-musallam
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed1c5c2
Status: ✅  Deploy successful!
Preview URL: https://07ca5a05.react-science.pages.dev
Branch Preview URL: https://render-boolean-info-panel.react-science.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (707c929) 46.80% compared to head (ed1c5c2) 47.07%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/info-panel/InfoPanel.tsx 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   46.80%   47.07%   +0.26%     
==========================================
  Files         149      145       -4     
  Lines        7950     7565     -385     
  Branches      146      146              
==========================================
- Hits         3721     3561     -160     
+ Misses       4229     4004     -225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamed-musallam
Copy link
Contributor Author

Could you merge this PR because i do not have the privilege to do that and create a patch release of react-science

@stropitek
Copy link
Contributor

stropitek commented Dec 6, 2023

We discussed this and agreed that showing Yes / No as values would be better than true / false

@lpatiny lpatiny merged commit 40314a6 into main Dec 6, 2023
12 checks passed
@lpatiny lpatiny deleted the render-boolean-info-panel branch December 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spectra information panel not rendering the boolean object correctly in the table
5 participants