Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blueprintjs Radio in RadioGroup #664

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

wadjih-bencheikh18
Copy link
Member

closes : #662

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Feb 12, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cf974f
Status: ✅  Deploy successful!
Preview URL: https://64709eea.react-science.pages.dev
Branch Preview URL: https://662-use-blueprintjs-radio-in.react-science.pages.dev

View logs

Copy link
Contributor

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove our legacy "classic" implementation of the radio button

You can remove the "type" prop from our component and always render the button variant.

You can remove the story that renders both variants side by side and replace with 2 control components, one for each component.

PS: there is an eslint error

@codecov-commenter
Copy link

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (48ae20c) 22.86% compared to head (4cf974f) 22.24%.
Report is 4 commits behind head on main.

Files Patch % Lines
stories/components/radio.stories.tsx 0.00% 28 Missing and 1 partial ⚠️
stories/components/form.stories.tsx 0.00% 13 Missing ⚠️
src/components/forms/radio-group/RadioGroup.tsx 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   22.86%   22.24%   -0.63%     
==========================================
  Files         221      220       -1     
  Lines       13080    13081       +1     
  Branches      235      236       +1     
==========================================
- Hits         2991     2910      -81     
- Misses      10000    10081      +81     
- Partials       89       90       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stropitek stropitek merged commit c944af2 into main Feb 19, 2024
12 checks passed
@stropitek stropitek deleted the 662-use-blueprintjs-radio-in-radiogroup branch February 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use blueprintjs Radio in RadioGroup
3 participants