-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use blueprintjs Radio in RadioGroup #664
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove our legacy "classic" implementation of the radio button
You can remove the "type" prop from our component and always render the button variant.
You can remove the story that renders both variants side by side and replace with 2 control components, one for each component.
PS: there is an eslint error
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 22.86% 22.24% -0.63%
==========================================
Files 221 220 -1
Lines 13080 13081 +1
Branches 235 236 +1
==========================================
- Hits 2991 2910 -81
- Misses 10000 10081 +81
- Partials 89 90 +1 ☔ View full report in Codecov by Sentry. |
closes : #662