feat: improve use select hook #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It accepts a 'defaultSelectedItem' property.
- You can specify which object serves as the label in two ways:
- Using the 'itemLabelKey' property, which accepts only keys where the value type is string.
- Using the 'itemLabelMap' function, which takes an item as a parameter and returns a string.
Deploying with
|
| Latest commit: |
eb4623e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8560cf9b.react-science.pages.dev |
| Branch Preview URL: | https://improve-use-select-hook.react-science.pages.dev |
|
could you take a look at this PR, Now the
|
stropitek
reviewed
Mar 14, 2024
- rename 'itemLabelKey' to 'itemTextKey' - rename 'itemLabelMap' to 'getItemText'
stropitek
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the useSelect hook :
defaultSelectedItemproperty.itemTextKeyproperty, which accepts only keys where the value type is a string.getItemTextfunction, which takes an item as a parameter and returns a string.