Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-511: change DocumentLSTMEmbeddings to use LSTM instead of GRU #512

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

kubapok
Copy link
Contributor

@kubapok kubapok commented Feb 16, 2019

add other available RNN types to choose from

@alanakbik
Copy link
Collaborator

Hey this is great, thanks for adding this.

However, I am getting an error now ('DocumentLSTMEmbeddings' object has no attribute 'embedding_length') if I call this code:

from flair.models import TextClassifier
classifier = TextClassifier.load('en-sentiment')

There may a problem with backwards compatibility with serialized models.

@alanakbik alanakbik changed the base branch from master to release-0.4.1 February 19, 2019 13:31
@alanakbik
Copy link
Collaborator

@kubapok thanks for commiting this - I'll merge this into the release branch and take alook at the error with the serialized models!

@alanakbik alanakbik merged commit 3934bff into flairNLP:release-0.4.1 Feb 19, 2019
alanakbik pushed a commit that referenced this pull request Feb 19, 2019
alanakbik pushed a commit that referenced this pull request Feb 19, 2019
stefan-it pushed a commit that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants