Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added some tests for #6499 #79

Open
GeeH opened this issue Jun 28, 2016 · 1 comment
Open

Added some tests for #6499 #79

GeeH opened this issue Jun 28, 2016 · 1 comment

Comments

@GeeH
Copy link
Contributor

GeeH commented Jun 28, 2016

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/6503
User: @rahuldroy
Created On: 2014-07-31T14:24:38Z
Updated At: 2015-05-07T13:37:25Z
Body


Comment

User: @Ocramius
Created On: 2014-07-31T15:11:25Z
Updated At: 2014-07-31T15:11:25Z
Body
Linking #6499


Comment

User: @weierophinney
Created On: 2014-08-07T16:42:14Z
Updated At: 2014-08-07T16:42:14Z
Body
@Ocramius is this an issue specific to our annotation support, or is it an issue in the Doctrine annotation library?


Comment

User: @Ocramius
Created On: 2014-08-07T16:49:09Z
Updated At: 2014-08-07T16:49:09Z
Body
Still not clear. I personally think Zend\Code may be passing a different string to the annotation parser.


Comment

User: @weierophinney
Created On: 2014-08-07T17:04:10Z
Updated At: 2014-08-07T17:04:10Z
Body
Removed milestone, as we cannot reliably reproduce.

In discussion with @Ocramius, it's possible that Zend\Code is passing an invalid string to the annotation parser. In looking at Zend\Code\Reflection\ClassReflection, however, the method we call is getAnnotations(), which passes the results of getDocComment() -- which is inherited directly from ReflectionClass. As such... this is very difficult to track.


Comment

User: @nickurt
Created On: 2014-08-08T08:45:05Z
Updated At: 2014-08-08T08:45:05Z
Body
@weierophinney @Ocramius Thanks for the reply's, I debugged some things.

The file Zend\Code\Scanner\AnnotationScanner -> __construct returns the correct docComment, but it fails in the tokenize function (#ref).

The currentChar (#ref) is here ...

string(1) "/"
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "
string(1) "
"
string(1) " "

Comment

User: @Ocramius
Created On: 2014-11-19T22:24:09Z
Updated At: 2014-11-19T22:24:09Z
Body
I see that this has indeed nothing to do with doctrine/annotations. Removing myself from the assignees as I cannot help with this issue right now.


Comment

User: @Maks3w
Created On: 2015-05-07T13:37:25Z
Updated At: 2015-05-07T13:37:25Z
Body
Do zendframework/zendframework#7113 fix this?


@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at laminas/laminas-code#21.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants