Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP2 : How to add MSS option on sending [SYN, ACK] to client? #30209

Closed
liang8057 opened this issue Nov 24, 2020 · 6 comments
Closed

TCP2 : How to add MSS option on sending [SYN, ACK] to client? #30209

liang8057 opened this issue Nov 24, 2020 · 6 comments
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features

Comments

@liang8057
Copy link

liang8057 commented Nov 24, 2020

I want to add mms to the tcp option during the three-way handshake.
Is there any API available?

@liang8057 liang8057 added the bug The issue is a bug, or the PR is fixing a bug label Nov 24, 2020
@jukkar
Copy link
Member

jukkar commented Nov 24, 2020

Currently the TCP stack does not add any tcp options when sending data. We could support TCP_MAXSEG socket option that the application could set. Patches are welcome if you want to implement it.

@jukkar jukkar added area: Networking Enhancement Changes/Updates/Additions to existing features and removed bug The issue is a bug, or the PR is fixing a bug labels Nov 24, 2020
@liang8057
Copy link
Author

Can TCP1 add mss tcp option?

@liang8057
Copy link
Author

I did not find the TCP_MAXSEG socket option, is there an example for reference?

@jukkar
Copy link
Member

jukkar commented Nov 26, 2020

Can TCP1 add mss tcp option?

Yes, there is some option setting in TCP1. Seach net_tcp_set_syn_opt() function.

@jukkar
Copy link
Member

jukkar commented Nov 26, 2020

I did not find the TCP_MAXSEG socket option, is there an example for reference?

Yes, see for example subsys/net/lib/sockets/sockets.c and zsock_setsockopt_ctx()

@carlescufi
Copy link
Member

Closing since it's out of date (TCP1 is no longer in the tree).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

3 participants