Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

power mgmt: pm_devices: Get rid of z_pm_core_devices array #32258

Closed
erwango opened this issue Feb 12, 2021 · 2 comments
Closed

power mgmt: pm_devices: Get rid of z_pm_core_devices array #32258

erwango opened this issue Feb 12, 2021 · 2 comments
Labels
area: Power Management Enhancement Changes/Updates/Additions to existing features
Milestone

Comments

@erwango
Copy link
Member

erwango commented Feb 12, 2021

Is your enhancement proposal related to a problem? Please describe.
When using PM_DEVICE, a z_pm_core_devices table is defined and has to be populated per platform but undocumented and its use is unclear.


/*
 * FIXME: Remove the conditional inclusion of
 * core_devices array once we enble the capability
 * to build the device list based on devices power
 * and clock domain dependencies.
 */

__weak const char *const z_pm_core_devices[] = {
#if defined(CONFIG_SOC_FAMILY_NRF)
	"CLOCK",
	"sys_clock",
	"UART_0",
#elif defined(CONFIG_SOC_SERIES_CC13X2_CC26X2)
	"sys_clock",
	"UART_0",
#elif defined(CONFIG_SOC_SERIES_KINETIS_K6X)
	DT_LABEL(DT_INST(0, nxp_kinetis_ethernet)),
#elif defined(CONFIG_NET_TEST)
	"",
#elif defined(CONFIG_SOC_SERIES_STM32L4X) || defined(CONFIG_SOC_SERIES_STM32WBX)
	"sys_clock",
	
#endif
	NULL
};

I think we should get rid of it in scope of PM_DEVICE rework

@erwango erwango added Enhancement Changes/Updates/Additions to existing features area: Power Management labels Feb 12, 2021
@erwango
Copy link
Member Author

erwango commented Feb 12, 2021

^^ @ceolin

@pabigot pabigot self-assigned this Feb 12, 2021
@pabigot pabigot removed their assignment Mar 7, 2021
@nashif nashif added this to the v2.6.0 milestone Mar 11, 2021
@nashif
Copy link
Member

nashif commented May 28, 2021

should be resolved now

@nashif nashif closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Power Management Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

3 participants