Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

st_ble_sensor sample references wrong attribute #36718

Closed
jefffhaynes opened this issue Jul 4, 2021 · 0 comments · Fixed by #36835
Closed

st_ble_sensor sample references wrong attribute #36718

jefffhaynes opened this issue Jul 4, 2021 · 0 comments · Fixed by #36835
Assignees
@erwango
Labels
area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@jefffhaynes
Copy link

zephyr/samples/bluetooth/st_ble_sensor/src/main.c

Line 121 in 91a6b28

err = bt_gatt_notify(NULL, &stsensor_svc.attrs[2],

This should reference attribute 4 (the button service), not 2 (the led service). As it stands, the sample does not notify correctly (or really, at all).
@erwango erwango self-assigned this Jul 5, 2021
@erwango erwango added area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Jul 5, 2021
@ikmdani ikmdani mentioned this issue Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

Labels
area: Bluetooth area: Samples Samples bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples/bluetooth: st_ble_sensor: Fixes the button activity notification ikmdani/zephyr
2 participants
@jefffhaynes @erwango