Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge vendor-prefixes.txt from all modules with build.settings.dts_root in zephyr/module.yml #37797

Closed
mniestroj opened this issue Aug 19, 2021 · 1 comment · Fixed by #37802
Assignees
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@mniestroj
Copy link
Member

Is your enhancement proposal related to a problem? Please describe.
Recently all device tree compatible strings are checked for valid vendor prefixes and a warning is generated if vendor is not listed in ${ZEPHYR_BASE}/dts/bindings/vendor-prefixes.txt. In case of twister builds warnings are errors by default, which results in CI failures. If downstream project has downstream drivers with downstream DT bindings with unknown vendor, then there is no easy way of extending list of possible vendors and suppressing generated warning/error.

Describe the solution you'd like
Iterate over all MODULE/dts/bindings/ directories that are used so far for DT bindings resolution and check if vendor-prefixes.txt exists there. If yes, then merge list of all vendors, so that warnings for downstream drivers (that use vendor unspecified in Zephyr's vendor-prefixes.txt) can be suppressed.

Additional context
Introduced checking of vendor-prefixes.txt breaks downstream projects that use twister in CI. The workaround for now is to disable "warnings as error" in twister or patching Zephyr's vendor-prefixes.txt.

@mniestroj mniestroj added the Enhancement Changes/Updates/Additions to existing features label Aug 19, 2021
@mbolivar-nordic
Copy link
Contributor

Implemented in #37802. Working in my testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants