Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwm2m: send_attempts field does not seem to be used? #39206

Closed
tautologyclub opened this issue Oct 6, 2021 · 4 comments
Closed

lwm2m: send_attempts field does not seem to be used? #39206

tautologyclub opened this issue Oct 6, 2021 · 4 comments
Assignees
Labels
area: LWM2M bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@tautologyclub
Copy link
Contributor

Zephyr version: 2.6.0

Just grepped for send_attempts and it does not seem to be used anywhere. Just incremented. client.retries is checked, but not send_attempts. I am not sure if this 100% means retransmits are borked, but that does feel like a possibility :)

@tautologyclub tautologyclub added the bug The issue is a bug, or the PR is fixing a bug label Oct 6, 2021
@tautologyclub
Copy link
Contributor Author

I can verify that it certainly seems that the stack has trouble resending. It just keeps trying until it runs out of allocated messages, then errors out.

@galak galak added area: LWM2M priority: low Low impact/importance bug labels Oct 7, 2021
@rlubos
Copy link
Contributor

rlubos commented Oct 8, 2021

@tautologyclub You're referencing outdated code - send_attempts field was removed a few months ago, as being unused, the retransmission logic is based on retry field from struct coap_pending (https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/net/lib/lwm2m/lwm2m_engine.c#L4133). Works with no issue with recent master.

@rlubos
Copy link
Contributor

rlubos commented Oct 8, 2021

Retransmission logic on 2.6.0 works fine as well on my side.

@carlescufi
Copy link
Member

@tautologyclub as per @rlubos's analysis, this does not seem to be an actual, current issue. If you still think this is a real bug, please reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LWM2M bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants