Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 🐞]: Ghosted parts still appear in Community Category Kit Filter #123

Closed
RobotGuy opened this issue Jun 19, 2022 · 3 comments · Fixed by #129
Closed

[Bug 🐞]: Ghosted parts still appear in Community Category Kit Filter #123

RobotGuy opened this issue Jun 19, 2022 · 3 comments · Fixed by #129
Assignees
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type

Comments

@RobotGuy
Copy link

Brief description of your issue

When viewing the parts under the SimpleConstruction! filter in the VAB you can still see the ghosted parts

Steps to reproduce

  • Have CCK, B9PartSwitch and SimpleConstruction! installed
  • Go to VAB
  • Click on the SimpleConstruction (EPL) filter on the left
  • See the three holding tanks, but also see all the ghosted holding tanks

Expected behavior

Not to be able to see the ghosted parts

Actual behavior

You can see the ghosted parts

Environment

Mod : Version SimpleConstruction-4.0.99.7-prerelease-CF
KSP : Version 1.12.3.3173 (BG 1.7.1, MK1.12.1)
Downloaded : Curseforge

How did you download and install this?

CurseForge (download and manual installation)

@github-actions
Copy link

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

@RobotGuy
Copy link
Author

As a quick fix, I added to the ghosting patch in /Config/SimpleConstruction/Tanks.crf, the following:

@tags:NEEDS[B9PartSwitch|InterstellarFuelSwitch] ^= :\s*cck-sc cck-el\s*: :

And to the patch in /Compatibility/ghostparts.cfg, the following:

@tags ^= :\s*cck-sc cck-el\s*: :

Thus removing the CCK tags. This made the ghosted tanks go away.

@zer0Kerbal zer0Kerbal added bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type labels Jun 23, 2022
@zer0Kerbal zer0Kerbal added this to the 4.0.99.8-prerelease milestone Jun 23, 2022
@zer0Kerbal
Copy link
Owner

Thank you @RobotGuy !

Having issues with my computer, went on a trip and unplugged the dev machine, turns out the CMOS battery died, and the BIOS went back to A05 from A25... i'm on the backup machine - but will attempt to push this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: config issue type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants