do not reset videojs when autoSetupTimeout called on autoSetup retry #3233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When autoSetupTimeout is called as a retry, it resets videojs variable to undefined, failing consequent auto-setup. See autoSetupTimeout in src/js/setup.js:
if (mediaEl && mediaEl.getAttribute) {
// ...
} else {
autoSetupTimeout(1);
break;
}
Solution
Avoid videojs redefinition when autoSetupTimeout called without second argument (on autoSetup retry). It solves issue #2386.