Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Créer une application Scalingo avec une configuration valide via Slack #168

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

yoandl
Copy link
Contributor

@yoandl yoandl commented Dec 2, 2022

🎄 Problème

La création d'une application via Slack n'active pas les options attendues par Steampipe.
De plus, le nom de l'application est contrôlé, mais s'il n'est pas correct, le message d'erreur ne mentionne pas les règles attendues.

🎁 Proposition

Ajouter automatiquement les options concernées.
Si le nom de l'application est incorrect, mentionner les règles attendues.

🌟 Remarques

Ajout de tests manquants.

🎅 Pour tester

Configurer PixBotTest:

  • supprimer le ngrok
  • mettre à jour le manifeste depuis https://pix-bot-review-pr168.osc-fr1.scalingo.io/run/manifest

Dans tech-releases, saisir scalingo

Vérifier que l'application est créée avec:

  • les logs routeurs
  • le force_https à true

@yoandl yoandl changed the title Ajout d'options par défaut à la création d'application sur Scalingo Ajout d'une configuration par défaut à la création d'application sur Scalingo Dec 2, 2022
@yoandl yoandl changed the title Ajout d'une configuration par défaut à la création d'application sur Scalingo Ajout d'une configuration valide par défaut à la création d'application sur Scalingo Dec 2, 2022
@octo-topi octo-topi changed the title Ajout d'une configuration valide par défaut à la création d'application sur Scalingo Créer une application Scalingo avec une configuration valide via Slack Dec 2, 2022
@octo-topi octo-topi added team-captains This is your captain speaking Development in progress labels Dec 2, 2022
@octo-topi octo-topi force-pushed the improv-scalingo-app-creation-from-slack branch from 564c7a2 to 58422a9 Compare December 2, 2022 10:08
@octo-topi octo-topi force-pushed the improv-scalingo-app-creation-from-slack branch 3 times, most recently from f540269 to cf7a5f1 Compare December 2, 2022 11:22
@mickaelalibert mickaelalibert force-pushed the improv-scalingo-app-creation-from-slack branch from f129400 to fe9b10e Compare December 2, 2022 14:54
@gitguardian
Copy link

gitguardian bot commented Dec 2, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mickaelalibert mickaelalibert force-pushed the improv-scalingo-app-creation-from-slack branch from fe9b10e to 2fa1998 Compare December 2, 2022 14:55
@octo-topi octo-topi force-pushed the improv-scalingo-app-creation-from-slack branch from 2fa1998 to e5bd4ad Compare December 2, 2022 14:59
@octo-topi octo-topi marked this pull request as ready for review December 2, 2022 15:04
@octo-topi octo-topi force-pushed the improv-scalingo-app-creation-from-slack branch from 9d8924f to 8db2821 Compare December 2, 2022 16:59
@octo-topi octo-topi force-pushed the improv-scalingo-app-creation-from-slack branch from 8db2821 to 4fd1f81 Compare December 2, 2022 17:01
@octo-topi
Copy link
Contributor

Mob dev & review OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants