[TECH] Linter les tests de manière homogène #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
approved these changes
Dec 16, 2022
octo-topi
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La configuration n'est pas la même que le monorepo: on ne vérifie pas la présence de tests exclusifs
only, désactivésskipCela engendre de la confusion
🤖 Solution
Utiliser la même configuration du plugin eslint
mocha🌈 Remarques
On pourrait partager la configuration pour éviter les désynchronisations.
💯 Pour tester
Ajouter un test exclusif avec
only.Vérifier que la CI fail.