[TECH] Refactorer le logger #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr254.review.pix.fr |
annemarie35
approved these changes
May 30, 2023
annemarie35
reviewed
May 30, 2023
octo-topi
force-pushed
the
refactor-logger
branch
from
9f63a1e
to
937e38a
Compare
emeric-martineau
approved these changes
Sep 7, 2023
annemarie35
force-pushed
the
refactor-logger
branch
from
937e38a
to
5bb0e29
Compare
annemarie35
approved these changes
Sep 8, 2023
annemarie35
reviewed
Sep 8, 2023
emeric-martineau
approved these changes
Sep 8, 2023
octo-topi
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
github-actions
bot
force-pushed
the
refactor-logger
branch
from
6df9963
to
b78e110
Compare
mickaelalibert
approved these changes
Sep 12, 2023
| event, | ||
| message: typeof message === 'object' ? JSON.stringify(message) : message, | ||
| job, | ||
| stack: typeof stack === 'object' ? JSON.stringify(stack) : stack, |
There was a problem hiding this comment.
Marrant parce qu'on avait fait ça avant :
stack = JSON.stringify(message);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Le logger utilise
En plus, on logge le message au lieu de la stack.
🤖 Proposition
Créer un nouvel objet.
Nommer le paramètre.
Logger le message au lieu de la stack.
💯 Pour tester
Vérifier la CI