-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Rend les déploiements déclaratif plutot qu'impératif #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: François de Metz <francois.de-metz@pix.fr>
Co-authored-by: Mickaël Alibert <mickael.alibert@pix.fr> Co-authored-by: Guillaume Lagorce <guillaume.lagorce@pix.fr>
Co-authored-by: Mickaël Alibert <mickael.alibert@pix.fr> Co-authored-by: Guillaume Lagorce <guillaume.lagorce@pix.fr>
Co-authored-by: Mickaël Alibert <mickael.alibert@pix.fr> Co-authored-by: Guillaume Lagorce <guillaume.lagorce@pix.fr>
francois2metz
changed the title
[TECH] Permet de configurer les déploiements
[TECH] Rend les déploiements déclaratif plutot qu'impératif
Jul 18, 2023
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr278.review.pix.fr |
francois2metz
force-pushed
the
configuration-improvement
branch
from
July 18, 2023 15:13
1d1732a
to
d6f72c1
Compare
Co-authored-by: François de Metz <francois.de-metz@pix.fr> Co-authored-by: Guillaume Lagorce <guillaume.lagorce@pix.fr>
francois2metz
force-pushed
the
configuration-improvement
branch
from
July 18, 2023 15:17
d6f72c1
to
6085456
Compare
HEYGUL
approved these changes
Jul 18, 2023
mickaelalibert
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
francois2metz
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Il y a actuellement beaucoup de code pour déployer des dépôts, tout cela réparti dans plusieurs fichiers avec moult tests.
Le rajout/modification/suppression d'un déploiement est pénible et n'est pas clair.
🤖 Proposition
Avoir un fichier de configuration pour centraliser tout cela.
🌈 Remarques
Nous n'avons géré que le déploiement par branche pour le moment. Le reste est a venir.
💯 Pour tester
🟢