[BUGFIX] Gérer les erreurs Scalingo lors du déploiement des applications d'integration #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yoan de Luca <yoan.de-luca@pix.fr> Co-authored-by: Pierre Top <pierre.top@pix.fr>
|
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr292.review.pix.fr |
mickaelalibert
changed the title
octo-topi
approved these changes
Aug 23, 2023
octo-topi
added
🚀 Ready to Merge
team-captains
github-actions
bot
deleted the
handle-scalingo-error-during-deployement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lorsqu'un push est effectué sur le monorepo, Pix bot renvoie une 500 sans aucune information en raison de l'objet erreur renvoyé par scalingo, qui n'a pas de setter sur la propriété Data, que Hapi tente de modifier
🤖 Proposition
Catcher les erreurs Scalingo et les renvoyer à Hapi sous la forme d'erreurs classiques
💯 Pour tester
🟢