Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Vérifier que la configuration Scalingo est fournie avant l'appel d'authentification #293

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

mickaelalibert
Copy link
Contributor

@mickaelalibert mickaelalibert commented Aug 23, 2023

🦄 Problème

Dans le cas ou les variables d'environnement configurant le client scalingo ne serait pas définies, Pix bot renvoie une erreur sans l'expliciter

🤖 Proposition

Gérer le cas ou les identifiants utilisés ne sont pas définis.

💯 Pour tester

🟢

mickaelalibert and others added 2 commits August 23, 2023 17:52
Co-authored-by: Pierre Top <pierre.top@pix.fr>
Co-authored-by: Pierre Top <pierre.top@pix.fr>
@octo-topi octo-topi added 🚀 Ready to Merge team-captains This is your captain speaking labels Aug 23, 2023
@octo-topi octo-topi self-assigned this Aug 23, 2023
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr293.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr293/environment

@mickaelalibert mickaelalibert changed the title Check for scalingo configuration [BUGFIX] Vérifier que la configuration Scalingo est fournie avant l'appel d'authentification Aug 23, 2023
@github-actions github-actions bot merged commit f4c41b1 into main Aug 24, 2023
8 checks passed
@github-actions github-actions bot deleted the check-for-scalingo-configuration branch August 24, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants