[FEATURE] ✨ Envoyer un message sur slack en cas de changements sur le fichier config.js #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelalibert
added
team-captains
|
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr310.review.pix.fr |
emeric-martineau
force-pushed
the
notify-slack-channel-on-config-file-changed
branch
from
f628ee6
to
010ab4a
Compare
mickaelalibert
force-pushed
the
notify-slack-channel-on-config-file-changed
branch
3 times, most recently
from
99c76fa
to
0fc2d4b
Compare
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
test/unit/common/services/slack/surfaces/messages/post-message_test.js
Outdated
Show resolved
Hide resolved
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
octo-topi
reviewed
Sep 15, 2023
emeric-martineau
force-pushed
the
notify-slack-channel-on-config-file-changed
branch
from
68be686
to
0ededb8
Compare
octo-topi
force-pushed
the
notify-slack-channel-on-config-file-changed
branch
from
0ededb8
to
c2b1546
Compare
Co-authored-by: Emeric Martineau <emeric.martineau@pix.fr>
octo-topi
force-pushed
the
notify-slack-channel-on-config-file-changed
branch
from
c2b1546
to
683e80a
Compare
octo-topi
added
🚀 Ready to Merge
Tech Review OK
and removed
Development in progress
labels
octo-topi
approved these changes
Sep 15, 2023
github-actions
bot
deleted the
notify-slack-channel-on-config-file-changed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lors du workflow Slack de MEP/PE, seul les gens ayant déclenché la modale sont prévenus des changements sur le fichier api/lib/config.js
🤖 Proposition
Prévenir l'ensemble des personnes sur le channel de release de la modification du fichier, en envoyant un message.
🌈 Remarques
Apportant le détail des PR concernées.
💯 Pour tester
Utiliser Slack de test, relié à l'application Scalingo
pix-bot-integration