-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Afficher le label de la team concernée et le lien vers la PR associée au changement de config #313
Merged
github-actions
merged 1 commit into
main
from
add-pr-and-labels-in-mer-config-change-slack-message
Sep 26, 2023
Merged
[TECH] Afficher le label de la team concernée et le lien vers la PR associée au changement de config #313
github-actions
merged 1 commit into
main
from
add-pr-and-labels-in-mer-config-change-slack-message
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr313.review.pix.fr |
annemarie35
force-pushed
the
add-pr-and-labels-in-mer-config-change-slack-message
branch
8 times, most recently
from
September 19, 2023 14:56
bc33563
to
884ff39
Compare
annemarie35
changed the title
✨ display PR link and label for related config change commit
[TECH] Afficher le label de la team concernée et le lien vers la PR associée au changement de config
Sep 20, 2023
annemarie35
added
Development in progress
👀 Tech Review Needed
and removed
Development in progress
labels
Sep 20, 2023
annemarie35
force-pushed
the
add-pr-and-labels-in-mer-config-change-slack-message
branch
from
September 22, 2023 08:13
884ff39
to
4fc2ff4
Compare
annemarie35
force-pushed
the
add-pr-and-labels-in-mer-config-change-slack-message
branch
3 times, most recently
from
September 22, 2023 14:11
afcdcae
to
7f7abc6
Compare
octo-topi
force-pushed
the
add-pr-and-labels-in-mer-config-change-slack-message
branch
from
September 26, 2023 08:13
7f7abc6
to
bad1bf2
Compare
octo-topi
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
Sep 26, 2023
octo-topi
approved these changes
Sep 26, 2023
github-actions
bot
deleted the
add-pr-and-labels-in-mer-config-change-slack-message
branch
September 26, 2023 08:18
emeric-martineau
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Lorsqu'un changement de config a été effectuée lors d'une mise en recette, un message est désormais envoyé sur tech release. Cependant nous n'affichons que le lien vers la diff de version.
🤖 Proposition
Pour améliorer le processus, nous allons afficher dans le message et le label de la team concernée et le lien vers la PR associée au changement de config
💯 Pour tester
Créer deux PR qui modifient la config sur https://github.com/1024pix/pix-renovate-test.
Lancer l'action sur le slack Pix bot test.