Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Afficher le label de la team concernée et le lien vers la PR associée au changement de config #313

Merged

Conversation

annemarie35
Copy link
Contributor

@annemarie35 annemarie35 commented Sep 19, 2023

🦄 Problème

Lorsqu'un changement de config a été effectuée lors d'une mise en recette, un message est désormais envoyé sur tech release. Cependant nous n'affichons que le lien vers la diff de version.

🤖 Proposition

Pour améliorer le processus, nous allons afficher dans le message et le label de la team concernée et le lien vers la PR associée au changement de config

💯 Pour tester

Créer deux PR qui modifient la config sur https://github.com/1024pix/pix-renovate-test.
Lancer l'action sur le slack Pix bot test.

@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr313.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-bot-review-pr313/environment

@annemarie35 annemarie35 force-pushed the add-pr-and-labels-in-mer-config-change-slack-message branch 8 times, most recently from bc33563 to 884ff39 Compare September 19, 2023 14:56
@annemarie35 annemarie35 self-assigned this Sep 20, 2023
@annemarie35 annemarie35 added the team-captains This is your captain speaking label Sep 20, 2023
@annemarie35 annemarie35 changed the title ✨ display PR link and label for related config change commit [TECH] Afficher le label de la team concernée et le lien vers la PR associée au changement de config Sep 20, 2023
@annemarie35 annemarie35 force-pushed the add-pr-and-labels-in-mer-config-change-slack-message branch from 884ff39 to 4fc2ff4 Compare September 22, 2023 08:13
@annemarie35 annemarie35 force-pushed the add-pr-and-labels-in-mer-config-change-slack-message branch 3 times, most recently from afcdcae to 7f7abc6 Compare September 22, 2023 14:11
common/services/github.js Outdated Show resolved Hide resolved
common/services/github.js Outdated Show resolved Hide resolved
test/acceptance/build/slack_test.js Show resolved Hide resolved
@octo-topi octo-topi force-pushed the add-pr-and-labels-in-mer-config-change-slack-message branch from 7f7abc6 to bad1bf2 Compare September 26, 2023 08:13
@octo-topi
Copy link
Contributor

Func review mob
image

@github-actions github-actions bot merged commit 67106a9 into main Sep 26, 2023
9 checks passed
@github-actions github-actions bot deleted the add-pr-and-labels-in-mer-config-change-slack-message branch September 26, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants