[Feature] Ajout d'info dans les message slack de PRs #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aceol
changed the title
aceol
force-pushed
the
pr-reviews-info
branch
2 times, most recently
from
91db292
to
fbee370
Compare
VincentHardouin
approved these changes
May 12, 2021
effectivement, ca m'a perturbé en arrivant sur ce fichier. Si tu veux t'en occuper n'hésites pas, sinon j'essaie de le faire dans la journée |
jonasgrilleres
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
On manque d'information sur les reviews affichés dans slack.
🤖 Solution
Afficher le statut des review (nombre d'
approved, nombre decommentset derequest change)🌈 Remarques
On trie en plaçant en dernier les PR en cours de développement
💯 Pour tester
En local uniquement.
Lancer Pix-bot avec npm start.
Lancer ngrock avec ngrok http 3000.
Configurer la commande /pr-pix de l'environnement Slack Pix-Bot-Test avec l'adresse donnée par ngrok suivi de /slack/commands/pr-pix
Taper la commande
/pr-pix cross-teamVerifier le message afficher