Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patch() API call for manually created Secret which belongs to ServiceAccount #149

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

seleznev
Copy link
Collaborator

@seleznev seleznev commented Aug 8, 2023

Otherwise k8s-handle removes content of a Secret (including an API token) at every deploy. It can lead to unexpected results if you rotate private keys for kube-controller-manager frequently.

@seleznev seleznev added the enhancement New feature or request label Aug 8, 2023
@seleznev seleznev requested review from yshch, halvaborsch, a user and nevlkv August 8, 2023 04:52
@seleznev seleznev self-assigned this Aug 8, 2023
@seleznev seleznev merged commit aebc8fb into master Aug 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants